dsa: reduce Box<[u8]> allocation in SignatureEncoding::to_vec
#969
Conversation
|
|
||
| use crate::Signature; | ||
|
|
||
| pub(crate) struct SignatureBoxed { |
There was a problem hiding this comment.
That is essentially what dsa::Signature is (dsa::Signature is composed of NonZero<BoxedUint>)
There was a problem hiding this comment.
wouldn't it be possible to get an iterator over the inner limbs? and get big endian from there? without allocating a new box.
There was a problem hiding this comment.
der checks for leading zeros when encoding UIntRef, so it would be too tricky
There was a problem hiding this comment.
well that's just up to the consumer of the said iterator to strip leading zeroes? I don't know.
There was a problem hiding this comment.
yeah nevermind, you have to have a buffer for SignatureRef, that can't be an iterator of limbs.
|
The Perhaps support could be added there so there's not need for complex encoding logic in the |
dsa: refactor: move `SignatureRef` to `signature_ref.rs`
dishmaker
force-pushed
the
dishmaker/dsa_reduce_alloc_der_encode
branch
from
864c3b6 to
0d62c1f
Compare
3 participants
Rewritten as
SignatureRef